mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-08-22 17:01:14 +00:00
Code Issues Releases Wiki Activity

drivers: staging: vme: Fixed checking NULL and 0 code style

Browse source 
Signed-off-by: Egor Uleyskiy <egor.ulieiskii@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Egor Uleyskiy 2015-11-22 11:27:56 +02:00 committed by Greg Kroah-Hartman
parent 48a42206dd
commit 59a04f1135
3 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/staging/vme/devices/vme_pio2_core.c
View file

@ -230,7 +230,7 @@ static int pio2_probe(struct vme_dev *vdev)
card->vdev = vdev; card->vdev = vdev;
for (i = 0; i < PIO2_VARIANT_LENGTH; i++) { for (i = 0; i < PIO2_VARIANT_LENGTH; i++) {
if (isdigit(card->variant[i]) == 0) { if (!isdigit(card->variant[i])) {
dev_err(&card->vdev->dev, "Variant invalid\n"); dev_err(&card->vdev->dev, "Variant invalid\n");
retval = -EINVAL; retval = -EINVAL;
goto err_variant; goto err_variant;

2
drivers/staging/vme/devices/vme_pio2_gpio.c
View file

@ -190,7 +190,7 @@ int pio2_gpio_init(struct pio2_card *card)
label = kasprintf(GFP_KERNEL, label = kasprintf(GFP_KERNEL,
"%s@%s", driver_name, dev_name(&card->vdev->dev)); "%s@%s", driver_name, dev_name(&card->vdev->dev));
if (label == NULL) if (!label)
return -ENOMEM; return -ENOMEM;
card->gc.label = label; card->gc.label = label;

12
drivers/staging/vme/devices/vme_user.c
View file

@ -309,7 +309,7 @@ static int vme_user_ioctl(struct inode *inode, struct file *file,
case VME_IRQ_GEN: case VME_IRQ_GEN:
copied = copy_from_user(&irq_req, argp, copied = copy_from_user(&irq_req, argp,
sizeof(irq_req)); sizeof(irq_req));
if (copied != 0) { if (copied) {
pr_warn("Partial copy from userspace\n"); pr_warn("Partial copy from userspace\n");
return -EFAULT; return -EFAULT;
} }
@ -335,7 +335,7 @@ static int vme_user_ioctl(struct inode *inode, struct file *file,
copied = copy_to_user(argp, &master, copied = copy_to_user(argp, &master,
sizeof(master)); sizeof(master));
if (copied != 0) { if (copied) {
pr_warn("Partial copy to userspace\n"); pr_warn("Partial copy to userspace\n");
return -EFAULT; return -EFAULT;
} }
@ -350,7 +350,7 @@ static int vme_user_ioctl(struct inode *inode, struct file *file,
} }
copied = copy_from_user(&master, argp, sizeof(master)); copied = copy_from_user(&master, argp, sizeof(master));
if (copied != 0) { if (copied) {
pr_warn("Partial copy from userspace\n"); pr_warn("Partial copy from userspace\n");
return -EFAULT; return -EFAULT;
} }
@ -380,7 +380,7 @@ static int vme_user_ioctl(struct inode *inode, struct file *file,
copied = copy_to_user(argp, &slave, copied = copy_to_user(argp, &slave,
sizeof(slave)); sizeof(slave));
if (copied != 0) { if (copied) {
pr_warn("Partial copy to userspace\n"); pr_warn("Partial copy to userspace\n");
return -EFAULT; return -EFAULT;
} }
@ -390,7 +390,7 @@ static int vme_user_ioctl(struct inode *inode, struct file *file,
case VME_SET_SLAVE: case VME_SET_SLAVE:
copied = copy_from_user(&slave, argp, sizeof(slave)); copied = copy_from_user(&slave, argp, sizeof(slave));
if (copied != 0) { if (copied) {
pr_warn("Partial copy from userspace\n"); pr_warn("Partial copy from userspace\n");
return -EFAULT; return -EFAULT;
} }
@ -757,7 +757,7 @@ static int __init vme_user_init(void)
* we just change the code in vme_user_match(). * we just change the code in vme_user_match().
*/ */
retval = vme_register_driver(&vme_user_driver, VME_MAX_SLOTS); retval = vme_register_driver(&vme_user_driver, VME_MAX_SLOTS);
if (retval != 0) if (retval)
goto err_reg; goto err_reg;
return retval; return retval;