mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-24 09:50:04 +00:00
net: qmi_wwan: simplify a check in qmi_wwan_bind()
This code is easier to read if we specify which flags we want at the condition instead of at the top of the function. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Bjørn Mork <bjorn@mork.no> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
251da41301
commit
5ac24979dc
1 changed files with 2 additions and 2 deletions
|
@ -129,7 +129,6 @@ static int qmi_wwan_bind(struct usbnet *dev, struct usb_interface *intf)
|
|||
struct usb_interface_descriptor *desc = &intf->cur_altsetting->desc;
|
||||
struct usb_cdc_union_desc *cdc_union = NULL;
|
||||
struct usb_cdc_ether_desc *cdc_ether = NULL;
|
||||
u32 required = 1 << USB_CDC_HEADER_TYPE | 1 << USB_CDC_UNION_TYPE;
|
||||
u32 found = 0;
|
||||
struct usb_driver *driver = driver_of(intf);
|
||||
struct qmi_wwan_state *info = (void *)&dev->data;
|
||||
|
@ -197,7 +196,8 @@ static int qmi_wwan_bind(struct usbnet *dev, struct usb_interface *intf)
|
|||
}
|
||||
|
||||
/* did we find all the required ones? */
|
||||
if ((found & required) != required) {
|
||||
if (!(found & (1 << USB_CDC_HEADER_TYPE)) ||
|
||||
!(found & (1 << USB_CDC_UNION_TYPE))) {
|
||||
dev_err(&intf->dev, "CDC functional descriptors missing\n");
|
||||
goto err;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue