mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-30 08:02:30 +00:00
bnxt_en: reverse order of TX disable and carrier off
[ Upstream commit132e0b65dc
] A TX queue can potentially immediately timeout after it is stopped and the last TX timestamp on that queue was more than 5 seconds ago with carrier still up. Prevent these intermittent false TX timeouts by bringing down carrier first before calling netif_tx_disable(). Fixes:c0c050c58d
("bnxt_en: New Broadcom ethernet driver.") Signed-off-by: Edwin Peer <edwin.peer@broadcom.com> Signed-off-by: Michael Chan <michael.chan@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
a1b6925065
commit
5c54aaed07
1 changed files with 2 additions and 1 deletions
|
@ -8347,9 +8347,10 @@ void bnxt_tx_disable(struct bnxt *bp)
|
|||
txr->dev_state = BNXT_DEV_STATE_CLOSING;
|
||||
}
|
||||
}
|
||||
/* Drop carrier first to prevent TX timeout */
|
||||
netif_carrier_off(bp->dev);
|
||||
/* Stop all TX queues */
|
||||
netif_tx_disable(bp->dev);
|
||||
netif_carrier_off(bp->dev);
|
||||
}
|
||||
|
||||
void bnxt_tx_enable(struct bnxt *bp)
|
||||
|
|
Loading…
Reference in a new issue