mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 17:30:02 +00:00
drm/i915/display: Suppress "Combo PHY A HW state changed unexpectedly"
We know a problem exists in the ifwi shipped with the early pre-production Tigerlake and DG1 prototypes, later revisions are fine. However, CI still relies on the earlier ifwi and we grow tired of the volume of warnings as we wait for replacements. Since the warning is a bug, we do not want to lose the warning in its entirety, so only suppress the warning for the platforms currently exhibiting the issue. Suggested-by: José Roberto de Souza <gitlab@gitlab.freedesktop.org> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2411 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: José Roberto de Souza <jose.souza@intel.com> Reviewed-by: José Roberto de Souza <jose.souza@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20201127210059.10702-1-chris@chris-wilson.co.uk
This commit is contained in:
parent
c33f83fd48
commit
5cc2b61fb2
1 changed files with 16 additions and 4 deletions
|
@ -427,10 +427,22 @@ static void icl_combo_phys_uninit(struct drm_i915_private *dev_priv)
|
||||||
u32 val;
|
u32 val;
|
||||||
|
|
||||||
if (phy == PHY_A &&
|
if (phy == PHY_A &&
|
||||||
!icl_combo_phy_verify_state(dev_priv, phy))
|
!icl_combo_phy_verify_state(dev_priv, phy)) {
|
||||||
|
if (IS_TIGERLAKE(dev_priv) || IS_DG1(dev_priv)) {
|
||||||
|
/*
|
||||||
|
* A known problem with old ifwi:
|
||||||
|
* https://gitlab.freedesktop.org/drm/intel/-/issues/2411
|
||||||
|
* Suppress the warning for CI. Remove ASAP!
|
||||||
|
*/
|
||||||
|
drm_dbg_kms(&dev_priv->drm,
|
||||||
|
"Combo PHY %c HW state changed unexpectedly\n",
|
||||||
|
phy_name(phy));
|
||||||
|
} else {
|
||||||
drm_warn(&dev_priv->drm,
|
drm_warn(&dev_priv->drm,
|
||||||
"Combo PHY %c HW state changed unexpectedly\n",
|
"Combo PHY %c HW state changed unexpectedly\n",
|
||||||
phy_name(phy));
|
phy_name(phy));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
if (!has_phy_misc(dev_priv, phy))
|
if (!has_phy_misc(dev_priv, phy))
|
||||||
goto skip_phy_misc;
|
goto skip_phy_misc;
|
||||||
|
|
Loading…
Reference in a new issue