mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 01:10:04 +00:00
ring-buffer: Wrap a list.next reference with rb_list_head()
This reference at the end of rb_get_reader_page() was causing off-by-one writes to the prev pointer of the page after the reader page when that page is the head page, and therefore the reader page has the RB_PAGE_HEAD flag in its list.next pointer. This eventually results in a GPF in a subsequent call to rb_set_head_page() (usually from rb_get_reader_page()) when that prev pointer is dereferenced. The dereferenced register would characteristically have an address that appears shifted left by one byte (eg, ffxxxxxxxxxxxxyy instead of ffffxxxxxxxxxxxx) due to being written at an address one byte too high. Signed-off-by: David Sharp <dhsharp@google.com> LKML-Reference: <1262826727-9090-1-git-send-email-dhsharp@google.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
This commit is contained in:
parent
c6f7afaeed
commit
5ded3dc6a3
1 changed files with 1 additions and 1 deletions
|
@ -2906,7 +2906,7 @@ rb_get_reader_page(struct ring_buffer_per_cpu *cpu_buffer)
|
|||
*
|
||||
* Now make the new head point back to the reader page.
|
||||
*/
|
||||
reader->list.next->prev = &cpu_buffer->reader_page->list;
|
||||
rb_list_head(reader->list.next)->prev = &cpu_buffer->reader_page->list;
|
||||
rb_inc_page(cpu_buffer, &cpu_buffer->head_page);
|
||||
|
||||
/* Finally update the reader page to the new head */
|
||||
|
|
Loading…
Reference in a new issue