mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-25 02:09:42 +00:00
drm/rcar-du: Fix return value check in rcar_du_lvdsenc_get_resources()
In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Also remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> [Remove the unneeded mem == NULL check] Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Signed-off-by: Dave Airlie <airlied@redhat.com>
This commit is contained in:
parent
6b27f7f0e9
commit
5ec467a803
1 changed files with 2 additions and 11 deletions
|
@ -144,18 +144,9 @@ static int rcar_du_lvdsenc_get_resources(struct rcar_du_lvdsenc *lvds,
|
|||
sprintf(name, "lvds.%u", lvds->index);
|
||||
|
||||
mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, name);
|
||||
if (mem == NULL) {
|
||||
dev_err(&pdev->dev, "failed to get memory resource for %s\n",
|
||||
name);
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
lvds->mmio = devm_ioremap_resource(&pdev->dev, mem);
|
||||
if (lvds->mmio == NULL) {
|
||||
dev_err(&pdev->dev, "failed to remap memory resource for %s\n",
|
||||
name);
|
||||
return -ENOMEM;
|
||||
}
|
||||
if (IS_ERR(lvds->mmio))
|
||||
return PTR_ERR(lvds->mmio);
|
||||
|
||||
lvds->clock = devm_clk_get(&pdev->dev, name);
|
||||
if (IS_ERR(lvds->clock)) {
|
||||
|
|
Loading…
Reference in a new issue