mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-05 00:20:32 +00:00
team: no need to do team_notify_peers or team_mcast_rejoin when disabling port
team_notify_peers() will send ARP and NA to notify peers. team_mcast_rejoin() will send multicast join group message to notify peers. We should do this when enabling/changed to a new port. But it doesn't make sense to do it when a port is disabled. On the other hand, when we set mcast_rejoin_count to 2, and do a failover, team_port_disable() will increase mcast_rejoin.count_pending to 2 and then team_port_enable() will increase mcast_rejoin.count_pending to 4. We will send 4 mcast rejoin messages at latest, which will make user confused. The same with notify_peers.count. Fix it by deleting team_notify_peers() and team_mcast_rejoin() in team_port_disable(). Reported-by: Liang Li <liali@redhat.com> Fixes:fc423ff00d
("team: add peer notification") Fixes:492b200efd
("team: add support for sending multicast rejoins") Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
18ba58e1c2
commit
5ed9dc9910
1 changed files with 0 additions and 2 deletions
|
@ -985,8 +985,6 @@ static void team_port_disable(struct team *team,
|
||||||
team->en_port_count--;
|
team->en_port_count--;
|
||||||
team_queue_override_port_del(team, port);
|
team_queue_override_port_del(team, port);
|
||||||
team_adjust_ops(team);
|
team_adjust_ops(team);
|
||||||
team_notify_peers(team);
|
|
||||||
team_mcast_rejoin(team);
|
|
||||||
team_lower_state_changed(port);
|
team_lower_state_changed(port);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue