mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 03:10:12 +00:00
scsi: bfa: Do not dereference port before it is null checked
Port is deferenced before it is null sanity checked, hence we potentially have a null pointer dereference bug. Instead, initialise trl_enabled from port->fcs->bfa after we are sure port is not null. Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
parent
02ccda2a2f
commit
5f6ac2cee2
1 changed files with 2 additions and 2 deletions
|
@ -5827,13 +5827,13 @@ bfa_fcs_lport_get_rport_max_speed(bfa_fcs_lport_t *port)
|
||||||
bfa_port_speed_t max_speed = 0;
|
bfa_port_speed_t max_speed = 0;
|
||||||
struct bfa_port_attr_s port_attr;
|
struct bfa_port_attr_s port_attr;
|
||||||
bfa_port_speed_t port_speed, rport_speed;
|
bfa_port_speed_t port_speed, rport_speed;
|
||||||
bfa_boolean_t trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);
|
bfa_boolean_t trl_enabled;
|
||||||
|
|
||||||
|
|
||||||
if (port == NULL)
|
if (port == NULL)
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
fcs = port->fcs;
|
fcs = port->fcs;
|
||||||
|
trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);
|
||||||
|
|
||||||
/* Get Physical port's current speed */
|
/* Get Physical port's current speed */
|
||||||
bfa_fcport_get_attr(port->fcs->bfa, &port_attr);
|
bfa_fcport_get_attr(port->fcs->bfa, &port_attr);
|
||||||
|
|
Loading…
Reference in a new issue