mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-27 12:57:53 +00:00
irqchip/imx-irqsteer: Convert to platform_driver::remove_new() callback
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lore.kernel.org/r/c0e5afe62256860150d25bcf644f2b8d62794c86.1703284359.git.u.kleine-koenig@pengutronix.de
This commit is contained in:
parent
984e5c7b8d
commit
5fcf3688e8
1 changed files with 6 additions and 8 deletions
|
@ -231,7 +231,7 @@ static int imx_irqsteer_probe(struct platform_device *pdev)
|
|||
return ret;
|
||||
}
|
||||
|
||||
static int imx_irqsteer_remove(struct platform_device *pdev)
|
||||
static void imx_irqsteer_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct irqsteer_data *irqsteer_data = platform_get_drvdata(pdev);
|
||||
int i;
|
||||
|
@ -243,8 +243,6 @@ static int imx_irqsteer_remove(struct platform_device *pdev)
|
|||
irq_domain_remove(irqsteer_data->domain);
|
||||
|
||||
clk_disable_unprepare(irqsteer_data->ipg_clk);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
#ifdef CONFIG_PM
|
||||
|
@ -307,11 +305,11 @@ static const struct of_device_id imx_irqsteer_dt_ids[] = {
|
|||
|
||||
static struct platform_driver imx_irqsteer_driver = {
|
||||
.driver = {
|
||||
.name = "imx-irqsteer",
|
||||
.of_match_table = imx_irqsteer_dt_ids,
|
||||
.pm = &imx_irqsteer_pm_ops,
|
||||
.name = "imx-irqsteer",
|
||||
.of_match_table = imx_irqsteer_dt_ids,
|
||||
.pm = &imx_irqsteer_pm_ops,
|
||||
},
|
||||
.probe = imx_irqsteer_probe,
|
||||
.remove = imx_irqsteer_remove,
|
||||
.probe = imx_irqsteer_probe,
|
||||
.remove_new = imx_irqsteer_remove,
|
||||
};
|
||||
builtin_platform_driver(imx_irqsteer_driver);
|
||||
|
|
Loading…
Reference in a new issue