mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-20 09:31:09 +00:00
cifs: Fix the error length of VALIDATE_NEGOTIATE_INFO message
commite98ecc6e94
upstream. Commitd5c7076b77
("smb3: add smb3.1.1 to default dialect list") extend the dialects from 3 to 4, but forget to decrease the extended length when specific the dialect, then the message length is larger than expected. This maybe leak some info through network because not initialize the message body. After apply this patch, the VALIDATE_NEGOTIATE_INFO message length is reduced from 28 bytes to 26 bytes. Fixes:d5c7076b77
("smb3: add smb3.1.1 to default dialect list") Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com> Cc: <stable@vger.kernel.org> Acked-by: Paulo Alcantara (SUSE) <pc@cjr.nz> Reviewed-by: Tom Talpey <tom@talpey.com> Signed-off-by: Steve French <stfrench@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
0d814a2199
commit
60480291c1
1 changed files with 2 additions and 2 deletions
|
@ -1137,9 +1137,9 @@ int smb3_validate_negotiate(const unsigned int xid, struct cifs_tcon *tcon)
|
|||
pneg_inbuf->Dialects[0] =
|
||||
cpu_to_le16(server->vals->protocol_id);
|
||||
pneg_inbuf->DialectCount = cpu_to_le16(1);
|
||||
/* structure is big enough for 3 dialects, sending only 1 */
|
||||
/* structure is big enough for 4 dialects, sending only 1 */
|
||||
inbuflen = sizeof(*pneg_inbuf) -
|
||||
sizeof(pneg_inbuf->Dialects[0]) * 2;
|
||||
sizeof(pneg_inbuf->Dialects[0]) * 3;
|
||||
}
|
||||
|
||||
rc = SMB2_ioctl(xid, tcon, NO_FILE_ID, NO_FILE_ID,
|
||||
|
|
Loading…
Reference in a new issue