mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-06 16:49:22 +00:00
staging: netlogic: constify ethtool_ops structures
Check for ethtool_ops structures that are only stored in the ethtool_ops field of a net_device structure or passed as the second argument to netdev_set_default_ethtool_ops. These contexts are declared const, so ethtool_ops structures that have these properties can be declared as const also. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r disable optional_qualifier@ identifier i; position p; @@ static struct ethtool_ops i@p = { ... }; @ok1@ identifier r.i; struct net_device e; position p; @@ e.ethtool_ops = &i@p; @ok2@ identifier r.i; expression e; position p; @@ netdev_set_default_ethtool_ops(e, &i@p) @bad@ position p != {r.p,ok1.p,ok2.p}; identifier r.i; @@ i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct ethtool_ops i = { ... }; // </smpl> Suggested-by: Stephen Hemminger <stephen@networkplumber.org> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
44fae22b36
commit
608bc9562a
1 changed files with 1 additions and 1 deletions
|
@ -192,7 +192,7 @@ static int xlr_set_settings(struct net_device *ndev, struct ethtool_cmd *ecmd)
|
||||||
return phy_ethtool_sset(phydev, ecmd);
|
return phy_ethtool_sset(phydev, ecmd);
|
||||||
}
|
}
|
||||||
|
|
||||||
static struct ethtool_ops xlr_ethtool_ops = {
|
static const struct ethtool_ops xlr_ethtool_ops = {
|
||||||
.get_settings = xlr_get_settings,
|
.get_settings = xlr_get_settings,
|
||||||
.set_settings = xlr_set_settings,
|
.set_settings = xlr_set_settings,
|
||||||
};
|
};
|
||||||
|
|
Loading…
Reference in a new issue