mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-04 01:49:36 +00:00
[media] mt9m032.c: introduce missing initialization
The result of one call to a function is tested, and then at the second call to the same function, the previous result, and not the current result, is tested again. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression ret; identifier f; statement S1,S2; @@ *ret = f(...); if (\(ret != 0\|ret < 0\|ret == NULL\)) S1 ... when any *f(...); if (\(ret != 0\|ret < 0\|ret == NULL\)) S2 // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
parent
b25b895805
commit
612cd9e874
1 changed files with 1 additions and 1 deletions
|
@ -781,7 +781,7 @@ static int mt9m032_probe(struct i2c_client *client,
|
|||
ret = mt9m032_write(client, MT9M032_RESET, 1); /* reset on */
|
||||
if (ret < 0)
|
||||
goto error_entity;
|
||||
mt9m032_write(client, MT9M032_RESET, 0); /* reset off */
|
||||
ret = mt9m032_write(client, MT9M032_RESET, 0); /* reset off */
|
||||
if (ret < 0)
|
||||
goto error_entity;
|
||||
|
||||
|
|
Loading…
Reference in a new issue