ethtool: don't propagate EOPNOTSUPP from dumps
[ Upstream commitcbeb989e41
] The default dump handler needs to clear ret before returning. Otherwise if the last interface returns an inconsequential error this error will propagate to user space. This may confuse user space (ethtool CLI seems to ignore it, but YNL doesn't). It will also terminate the dump early for mutli-skb dump, because netlink core treats EOPNOTSUPP as a real error. Fixes:728480f124
("ethtool: default handlers for GET requests") Reviewed-by: Simon Horman <horms@kernel.org> Link: https://lore.kernel.org/r/20231126225806.2143528-1-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
658dc8b4a3
commit
61ae993c30
|
@ -505,6 +505,7 @@ static int ethnl_default_dumpit(struct sk_buff *skb,
|
|||
ret = skb->len;
|
||||
break;
|
||||
}
|
||||
ret = 0;
|
||||
}
|
||||
rtnl_unlock();
|
||||
|
||||
|
|
Loading…
Reference in New Issue