mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-02 07:04:24 +00:00
usbnet: ipheth: fix potential null pointer dereference in ipheth_carrier_set
_dev_ is being dereferenced before it is null checked, hence there
is a potential null pointer dereference.
Fix this by moving the pointer dereference after _dev_ has been null
checked.
Addresses-Coverity-ID: 1462020
Fixes: bb1b40c7cb
("usbnet: ipheth: prevent TX queue timeouts when device not ready")
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
981542c526
commit
61c59355e0
1 changed files with 4 additions and 1 deletions
|
@ -291,12 +291,15 @@ static void ipheth_sndbulk_callback(struct urb *urb)
|
||||||
|
|
||||||
static int ipheth_carrier_set(struct ipheth_device *dev)
|
static int ipheth_carrier_set(struct ipheth_device *dev)
|
||||||
{
|
{
|
||||||
struct usb_device *udev = dev->udev;
|
struct usb_device *udev;
|
||||||
int retval;
|
int retval;
|
||||||
|
|
||||||
if (!dev)
|
if (!dev)
|
||||||
return 0;
|
return 0;
|
||||||
if (!dev->confirmed_pairing)
|
if (!dev->confirmed_pairing)
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
|
udev = dev->udev;
|
||||||
retval = usb_control_msg(udev,
|
retval = usb_control_msg(udev,
|
||||||
usb_rcvctrlpipe(udev, IPHETH_CTRL_ENDP),
|
usb_rcvctrlpipe(udev, IPHETH_CTRL_ENDP),
|
||||||
IPHETH_CMD_CARRIER_CHECK, /* request */
|
IPHETH_CMD_CARRIER_CHECK, /* request */
|
||||||
|
|
Loading…
Reference in a new issue