mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-29 13:53:33 +00:00
Code Issues Releases Wiki Activity

scsi: ibmvfc: Make ibmvfc_wait_for_ops() MQ aware

Browse source 
During MQ enablement of the ibmvfc driver ibmvfc_wait_for_ops() was
missed. This function is responsible for waiting on commands to complete
that match a certain criteria such as LUN or cancel key. The implementation
as is only scans the CRQ for events ignoring any sub-queues and as a result
will exit successfully without doing anything when operating in MQ
channelized mode.

Check the MQ and channel use flags to determine which queues are
applicable, and scan each queue accordingly. Note in MQ mode SCSI commands
are only issued down sub-queues and the CRQ is only used for driver
specific management commands. As such the CRQ events are ignored when
operating in MQ mode with channels.

Link: https://lore.kernel.org/r/20210319205029.312969-3-tyreld@linux.ibm.com
Fixes: 9000cb998b ("scsi: ibmvfc: Enable MQ and set reasonable defaults")
Reviewed-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: Tyrel Datwyler <tyreld@linux.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Tyrel Datwyler 2021-03-19 14:50:29 -06:00 committed by Martin K. Petersen
parent 8b1c9b2025
commit 62fc266148
1 changed files with 34 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

51
drivers/scsi/ibmvscsi/ibmvfc.c
View file

@ -2403,41 +2403,58 @@ static int ibmvfc_wait_for_ops(struct ibmvfc_host *vhost, void *device,
{
struct ibmvfc_event *evt;
DECLARE_COMPLETION_ONSTACK(comp);
int wait, i;
int wait, i, q_index, q_size;
unsigned long flags;
signed long timeout = IBMVFC_ABORT_WAIT_TIMEOUT * HZ;
struct ibmvfc_queue *queues;
ENTER;
if (vhost->mq_enabled && vhost->using_channels) {
queues = vhost->scsi_scrqs.scrqs;
q_size = vhost->scsi_scrqs.active_queues;
} else {
queues = &vhost->crq;
q_size = 1;
}
do {
wait = 0;
spin_lock_irqsave(&vhost->crq.l_lock, flags);
for (i = 0; i < vhost->crq.evt_pool.size; i++) {
evt = &vhost->crq.evt_pool.events[i];
if (!ibmvfc_event_is_free(evt)) {
if (match(evt, device)) {
evt->eh_comp = &comp;
wait++;
spin_lock_irqsave(vhost->host->host_lock, flags);
for (q_index = 0; q_index < q_size; q_index++) {
spin_lock(&queues[q_index].l_lock);
for (i = 0; i < queues[q_index].evt_pool.size; i++) {
evt = &queues[q_index].evt_pool.events[i];
if (!ibmvfc_event_is_free(evt)) {
if (match(evt, device)) {
evt->eh_comp = &comp;
wait++;
}
}
}
spin_unlock(&queues[q_index].l_lock);
}
spin_unlock_irqrestore(&vhost->crq.l_lock, flags);
spin_unlock_irqrestore(vhost->host->host_lock, flags);
if (wait) {
timeout = wait_for_completion_timeout(&comp, timeout);
if (!timeout) {
wait = 0;
spin_lock_irqsave(&vhost->crq.l_lock, flags);
for (i = 0; i < vhost->crq.evt_pool.size; i++) {
evt = &vhost->crq.evt_pool.events[i];
if (!ibmvfc_event_is_free(evt)) {
if (match(evt, device)) {
evt->eh_comp = NULL;
wait++;
spin_lock_irqsave(vhost->host->host_lock, flags);
for (q_index = 0; q_index < q_size; q_index++) {
spin_lock(&queues[q_index].l_lock);
for (i = 0; i < queues[q_index].evt_pool.size; i++) {
evt = &queues[q_index].evt_pool.events[i];
if (!ibmvfc_event_is_free(evt)) {
if (match(evt, device)) {
evt->eh_comp = NULL;
wait++;
}
}
}
spin_unlock(&queues[q_index].l_lock);
}
spin_unlock_irqrestore(&vhost->crq.l_lock, flags);
spin_unlock_irqrestore(vhost->host->host_lock, flags);
if (wait)
dev_err(vhost->dev, "Timed out waiting for aborted commands\n");
LEAVE;