mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-24 01:41:39 +00:00
spi/topcliff-pch: Fix device remove function
The call sequence spi_alloc_master/spi_register_master/spi_unregister_master is complete; it reduces the device reference count to zero, which results in device memory being freed. An extra call to spi_master_put is unnecessary and results in an access to free memory. Drop it. Also, the device subsystem resets device driver data to NULL after the call to the remove function returns, so there is no need to do it here. Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
This commit is contained in:
parent
c68025bf03
commit
63002e84a8
1 changed files with 0 additions and 2 deletions
|
@ -1536,8 +1536,6 @@ static int __devexit pch_spi_pd_remove(struct platform_device *plat_dev)
|
||||||
|
|
||||||
pci_iounmap(board_dat->pdev, data->io_remap_addr);
|
pci_iounmap(board_dat->pdev, data->io_remap_addr);
|
||||||
spi_unregister_master(data->master);
|
spi_unregister_master(data->master);
|
||||||
spi_master_put(data->master);
|
|
||||||
platform_set_drvdata(plat_dev, NULL);
|
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue