mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-29 22:02:02 +00:00
Code Issues Releases Wiki Activity

net: ipconfig: use strscpy to replace strlcpy

Browse source 
The strlcpy should not be used because it doesn't limit the source
length. Preferred is strscpy.

Signed-off-by: XueBing Chen <chenxuebing@jari.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
XueBing Chen 2022-07-01 18:55:17 +08:00 committed by David S. Miller
parent 798661c736
commit 634b215b73
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
net/ipv4/ipconfig.c
View file

@ -1759,15 +1759,15 @@ static int __init ip_auto_config_setup(char *addrs)
case 4: case 4:
if ((dp = strchr(ip, '.'))) { if ((dp = strchr(ip, '.'))) {
*dp++ = '\0'; *dp++ = '\0';
strlcpy(utsname()->domainname, dp, strscpy(utsname()->domainname, dp,
sizeof(utsname()->domainname)); sizeof(utsname()->domainname));
} }
strlcpy(utsname()->nodename, ip, strscpy(utsname()->nodename, ip,
sizeof(utsname()->nodename)); sizeof(utsname()->nodename));
ic_host_name_set = 1; ic_host_name_set = 1;
break; break;
case 5: case 5:
strlcpy(user_dev_name, ip, sizeof(user_dev_name)); strscpy(user_dev_name, ip, sizeof(user_dev_name));
break; break;
case 6: case 6:
if (ic_proto_name(ip) == 0 && if (ic_proto_name(ip) == 0 &&
@ -1814,7 +1814,7 @@ __setup("nfsaddrs=", nfsaddrs_config_setup);
static int __init vendor_class_identifier_setup(char *addrs) static int __init vendor_class_identifier_setup(char *addrs)
{ {
if (strlcpy(vendor_class_identifier, addrs, if (strscpy(vendor_class_identifier, addrs,
sizeof(vendor_class_identifier)) sizeof(vendor_class_identifier))
>= sizeof(vendor_class_identifier)) >= sizeof(vendor_class_identifier))
pr_warn("DHCP: vendorclass too long, truncated to \"%s\"\n", pr_warn("DHCP: vendorclass too long, truncated to \"%s\"\n",