mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-06 08:46:46 +00:00
Code Issues Releases Wiki Activity

serial: 8250_bcm7271: Fix return value check in brcmuart_probe()

Browse source 
In case of error, the function devm_ioremap() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value
check should be replaced with NULL test.

Fixes: 41a469482d ("serial: 8250: Add new 8250-core based Broadcom STB driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Reviewed-by: Al Cooper <alcooperx@gmail.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20210329140659.1832950-1-weiyongjun1@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wei Yongjun 2021-03-29 14:06:59 +00:00 committed by Greg Kroah-Hartman
parent 211b4d42b7
commit 64b1510642
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/tty/serial/8250/8250_bcm7271.c
View file

@ -974,8 +974,8 @@ static int brcmuart_probe(struct platform_device *pdev)
break;
priv->regs[x] = devm_ioremap(dev, regs->start,
resource_size(regs));
if (IS_ERR(priv->regs[x]))
return PTR_ERR(priv->regs[x]);
if (!priv->regs[x])
return -ENOMEM;
if (x == REGS_8250) {
mapbase = regs->start;
membase = priv->regs[x];