mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-20 09:31:09 +00:00
ASoC: amd: change clk_get() to devm_clk_get() and add missed checks
[ Upstream commit95d3befbc5
] cz_da7219_init() does not check the return values of clk_get(), while da7219_clk_enable() calls clk_set_rate() to dereference the pointers. Add checks to fix the problems. Also, change clk_get() to devm_clk_get() to avoid data leak after failures. Fixes:bb24a31ed5
("ASoC: AMD: Configure wclk and bclk of master codec") Signed-off-by: Chuhong Yuan <hslester96@gmail.com> Link: https://lore.kernel.org/r/20201204063610.513556-1-hslester96@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
e52398d49d
commit
64ffbfb1d7
1 changed files with 7 additions and 2 deletions
|
@ -73,8 +73,13 @@ static int cz_da7219_init(struct snd_soc_pcm_runtime *rtd)
|
|||
return ret;
|
||||
}
|
||||
|
||||
da7219_dai_wclk = clk_get(component->dev, "da7219-dai-wclk");
|
||||
da7219_dai_bclk = clk_get(component->dev, "da7219-dai-bclk");
|
||||
da7219_dai_wclk = devm_clk_get(component->dev, "da7219-dai-wclk");
|
||||
if (IS_ERR(da7219_dai_wclk))
|
||||
return PTR_ERR(da7219_dai_wclk);
|
||||
|
||||
da7219_dai_bclk = devm_clk_get(component->dev, "da7219-dai-bclk");
|
||||
if (IS_ERR(da7219_dai_bclk))
|
||||
return PTR_ERR(da7219_dai_bclk);
|
||||
|
||||
ret = snd_soc_card_jack_new(card, "Headset Jack",
|
||||
SND_JACK_HEADSET | SND_JACK_LINEOUT |
|
||||
|
|
Loading…
Reference in a new issue