mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-30 22:26:55 +00:00
wifi: mac80211: mlme: assign link address correctly
[ Upstream commitacdc3e4788
] Right now, we assign the link address only after we add the link to the driver, which is quite obviously wrong. It happens to work in many cases because it gets updated immediately, and then link_conf updates may update it, but it's clearly not really right. Set the link address during ieee80211_mgd_setup_link() so it's set before telling the driver about the link. Fixes:81151ce462
("wifi: mac80211: support MLO authentication/association with one link") Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
c5fab887f2
commit
652b2ef552
1 changed files with 2 additions and 3 deletions
|
@ -6291,6 +6291,8 @@ void ieee80211_mgd_setup_link(struct ieee80211_link_data *link)
|
|||
if (sdata->u.mgd.assoc_data)
|
||||
ether_addr_copy(link->conf->addr,
|
||||
sdata->u.mgd.assoc_data->link[link_id].addr);
|
||||
else if (!is_valid_ether_addr(link->conf->addr))
|
||||
eth_random_addr(link->conf->addr);
|
||||
}
|
||||
|
||||
/* scan finished notification */
|
||||
|
@ -6378,9 +6380,6 @@ static int ieee80211_prep_connection(struct ieee80211_sub_if_data *sdata,
|
|||
goto out_err;
|
||||
}
|
||||
|
||||
if (mlo && !is_valid_ether_addr(link->conf->addr))
|
||||
eth_random_addr(link->conf->addr);
|
||||
|
||||
if (WARN_ON(!ifmgd->auth_data && !ifmgd->assoc_data)) {
|
||||
err = -EINVAL;
|
||||
goto out_err;
|
||||
|
|
Loading…
Reference in a new issue