mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 17:30:02 +00:00
hp100: fix an skb->len race
As soon as skb is given to hardware and spinlock released, TX completion can free skb under us. Therefore, we should update netdev stats before spinlock release. Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
00ce2d5614
commit
658924dc9a
1 changed files with 2 additions and 2 deletions
|
@ -1580,12 +1580,12 @@ static netdev_tx_t hp100_start_xmit_bm(struct sk_buff *skb,
|
|||
hp100_outl(ringptr->pdl_paddr, TX_PDA_L); /* Low Prio. Queue */
|
||||
|
||||
lp->txrcommit++;
|
||||
spin_unlock_irqrestore(&lp->lock, flags);
|
||||
|
||||
/* Update statistics */
|
||||
dev->stats.tx_packets++;
|
||||
dev->stats.tx_bytes += skb->len;
|
||||
|
||||
spin_unlock_irqrestore(&lp->lock, flags);
|
||||
|
||||
return NETDEV_TX_OK;
|
||||
|
||||
drop:
|
||||
|
|
Loading…
Reference in a new issue