mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 10:49:33 +00:00
power: supply: s3c_adc_battery: fix possible use-after-free in s3c_adc_bat_remove()
This driver's remove path calls cancel_delayed_work(). However, that function does not wait until the work function finishes. This means that the callback function may still be running after the driver's remove function has finished, which would result in a use-after-free. Fix by calling cancel_delayed_work_sync(), which ensures that the work is properly cancelled, no longer running, and unable to re-schedule itself. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
This commit is contained in:
parent
b6cfa007b3
commit
68ae256945
1 changed files with 1 additions and 1 deletions
|
@ -390,7 +390,7 @@ static int s3c_adc_bat_remove(struct platform_device *pdev)
|
||||||
if (main_bat.charge_finished)
|
if (main_bat.charge_finished)
|
||||||
free_irq(gpiod_to_irq(main_bat.charge_finished), NULL);
|
free_irq(gpiod_to_irq(main_bat.charge_finished), NULL);
|
||||||
|
|
||||||
cancel_delayed_work(&bat_work);
|
cancel_delayed_work_sync(&bat_work);
|
||||||
|
|
||||||
if (pdata->exit)
|
if (pdata->exit)
|
||||||
pdata->exit();
|
pdata->exit();
|
||||||
|
|
Loading…
Reference in a new issue