mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-22 17:01:14 +00:00
HID: wacom: fix bit shift for Cintiq Companion 2
The bit indicating BTN_6 on this device is overshifted
by 2 bits, resulting in the incorrect button being
reported.
Also fix copy-paste mistake in comments.
Signed-off-by: Aaron Armstrong Skomra <aaron.skomra@wacom.com>
Reviewed-by: Ping Cheng <ping.cheng@wacom.com>
Link: https://github.com/linuxwacom/xf86-input-wacom/issues/71
Fixes: c7f0522a1a
("HID: wacom: Slim down wacom_intuos_pad processing")
Cc: <stable@vger.kernel.org> # v4.5+
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
parent
7bc74853fd
commit
693c3dab4e
1 changed files with 6 additions and 6 deletions
|
@ -533,14 +533,14 @@ static int wacom_intuos_pad(struct wacom_wac *wacom)
|
||||||
*/
|
*/
|
||||||
buttons = (data[4] << 1) | (data[3] & 0x01);
|
buttons = (data[4] << 1) | (data[3] & 0x01);
|
||||||
} else if (features->type == CINTIQ_COMPANION_2) {
|
} else if (features->type == CINTIQ_COMPANION_2) {
|
||||||
/* d-pad right -> data[4] & 0x10
|
/* d-pad right -> data[2] & 0x10
|
||||||
* d-pad up -> data[4] & 0x20
|
* d-pad up -> data[2] & 0x20
|
||||||
* d-pad left -> data[4] & 0x40
|
* d-pad left -> data[2] & 0x40
|
||||||
* d-pad down -> data[4] & 0x80
|
* d-pad down -> data[2] & 0x80
|
||||||
* d-pad center -> data[3] & 0x01
|
* d-pad center -> data[1] & 0x01
|
||||||
*/
|
*/
|
||||||
buttons = ((data[2] >> 4) << 7) |
|
buttons = ((data[2] >> 4) << 7) |
|
||||||
((data[1] & 0x04) << 6) |
|
((data[1] & 0x04) << 4) |
|
||||||
((data[2] & 0x0F) << 2) |
|
((data[2] & 0x0F) << 2) |
|
||||||
(data[1] & 0x03);
|
(data[1] & 0x03);
|
||||||
} else if (features->type >= INTUOS5S && features->type <= INTUOSPL) {
|
} else if (features->type >= INTUOS5S && features->type <= INTUOSPL) {
|
||||||
|
|
Loading…
Reference in a new issue