mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-07 03:18:31 +00:00
iio:gyro:itg3200: Fix timestamp alignment and prevent data leak.
commit10ab7cfd55
upstream. One of a class of bugs pointed out by Lars in a recent review. iio_push_to_buffers_with_timestamp assumes the buffer used is aligned to the size of the timestamp (8 bytes). This is not guaranteed in this driver which uses a 16 byte array of smaller elements on the stack. This is fixed by using an explicit c structure. As there are no holes in the structure, there is no possiblity of data leakage in this case. The explicit alignment of ts is not strictly necessary but potentially makes the code slightly less fragile. It also removes the possibility of this being cut and paste into another driver where the alignment isn't already true. Fixes:36e0371e77
("iio:itg3200: Use iio_push_to_buffers_with_timestamp()") Reported-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: <Stable@vger.kernel.org> Link: https://lore.kernel.org/r/20200722155103.979802-6-jic23@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
c2a0f7d6a8
commit
6a969548a8
1 changed files with 10 additions and 3 deletions
|
@ -49,13 +49,20 @@ static irqreturn_t itg3200_trigger_handler(int irq, void *p)
|
||||||
struct iio_poll_func *pf = p;
|
struct iio_poll_func *pf = p;
|
||||||
struct iio_dev *indio_dev = pf->indio_dev;
|
struct iio_dev *indio_dev = pf->indio_dev;
|
||||||
struct itg3200 *st = iio_priv(indio_dev);
|
struct itg3200 *st = iio_priv(indio_dev);
|
||||||
__be16 buf[ITG3200_SCAN_ELEMENTS + sizeof(s64)/sizeof(u16)];
|
/*
|
||||||
|
* Ensure correct alignment and padding including for the
|
||||||
|
* timestamp that may be inserted.
|
||||||
|
*/
|
||||||
|
struct {
|
||||||
|
__be16 buf[ITG3200_SCAN_ELEMENTS];
|
||||||
|
s64 ts __aligned(8);
|
||||||
|
} scan;
|
||||||
|
|
||||||
int ret = itg3200_read_all_channels(st->i2c, buf);
|
int ret = itg3200_read_all_channels(st->i2c, scan.buf);
|
||||||
if (ret < 0)
|
if (ret < 0)
|
||||||
goto error_ret;
|
goto error_ret;
|
||||||
|
|
||||||
iio_push_to_buffers_with_timestamp(indio_dev, buf, pf->timestamp);
|
iio_push_to_buffers_with_timestamp(indio_dev, &scan, pf->timestamp);
|
||||||
|
|
||||||
iio_trigger_notify_done(indio_dev->trig);
|
iio_trigger_notify_done(indio_dev->trig);
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue