mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-05 02:19:51 +00:00
Code Issues Releases Wiki Activity

usb: host: ehci-tegra: Use devm_ioremap_resource instead of devm_ioremap

Browse source 
Using devm_ioremap_resource() API should actually be preferred over
devm_ioremap(), since the former request the mem region first and then
gives back the ioremap'ed memory pointer.
devm_ioremap_resource() calls request_mem_region(), therby preventing
other drivers to make any overlapping call to the same region.

Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Vivek Gautam 2014-05-10 17:30:09 +05:30 committed by Greg Kroah-Hartman
parent e0f77a91ee
commit 6ba96dcebf
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
drivers/usb/host/ehci-tegra.c
View file

@ -411,10 +411,9 @@ static int tegra_ehci_probe(struct platform_device *pdev)
} }
hcd->rsrc_start = res->start; hcd->rsrc_start = res->start;
hcd->rsrc_len = resource_size(res); hcd->rsrc_len = resource_size(res);
hcd->regs = devm_ioremap(&pdev->dev, res->start, resource_size(res)); hcd->regs = devm_ioremap_resource(&pdev->dev, res);
if (!hcd->regs) { if (IS_ERR(hcd->regs)) {
dev_err(&pdev->dev, "Failed to remap I/O memory\n"); err = PTR_ERR(hcd->regs);
err = -ENOMEM;
goto cleanup_clk_en; goto cleanup_clk_en;
} }
ehci->caps = hcd->regs + 0x100; ehci->caps = hcd->regs + 0x100;