mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 13:53:33 +00:00
wifi: rtw89: debug: Fix error handling in rtw89_debug_priv_btc_manual_set()
[ Upstream commit59b4cc439f
] If there is a failure during kstrtobool_from_user() rtw89_debug_priv_btc_manual_set should return a negative error code instead of returning the count directly. Fix this bug by returning an error code instead of a count after a failed call of the function "kstrtobool_from_user". Moreover I omitted the label "out" with this source code correction. Fixes:e3ec7017f6
("rtw89: add Realtek 802.11ax driver") Signed-off-by: Zhang Shurong <zhang_shurong@foxmail.com> Acked-by: Ping-Ke Shih <pkshih@realtek.com> Signed-off-by: Kalle Valo <kvalo@kernel.org> Link: https://lore.kernel.org/r/tencent_1C09B99BD7DA9CAD18B00C8F0F050F540607@qq.com Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
39a6b4bbc5
commit
6bf4ccafb3
1 changed files with 5 additions and 3 deletions
|
@ -2302,12 +2302,14 @@ static ssize_t rtw89_debug_priv_btc_manual_set(struct file *filp,
|
|||
struct rtw89_dev *rtwdev = debugfs_priv->rtwdev;
|
||||
struct rtw89_btc *btc = &rtwdev->btc;
|
||||
bool btc_manual;
|
||||
int ret;
|
||||
|
||||
if (kstrtobool_from_user(user_buf, count, &btc_manual))
|
||||
goto out;
|
||||
ret = kstrtobool_from_user(user_buf, count, &btc_manual);
|
||||
if (ret)
|
||||
return ret;
|
||||
|
||||
btc->ctrl.manual = btc_manual;
|
||||
out:
|
||||
|
||||
return count;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue