mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-19 09:04:57 +00:00
netfilter: flowtable: Remove redundant hw refresh bit
commitc07531c01d
upstream. Offloading conns could fail for multiple reasons and a hw refresh bit is set to try to reoffload it in next sw packet. But it could be in some cases and future points that the hw refresh bit is not set but a refresh could succeed. Remove the hw refresh bit and do offload refresh if requested. There won't be a new work entry if a work is already pending anyway as there is the hw pending bit. Fixes:8b3646d6e0
("net/sched: act_ct: Support refreshing the flow table entries") Signed-off-by: Roi Dayan <roid@nvidia.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
fe6921e3b8
commit
6d6bc8c752
3 changed files with 5 additions and 6 deletions
|
@ -126,7 +126,6 @@ enum nf_flow_flags {
|
|||
NF_FLOW_HW,
|
||||
NF_FLOW_HW_DYING,
|
||||
NF_FLOW_HW_DEAD,
|
||||
NF_FLOW_HW_REFRESH,
|
||||
NF_FLOW_HW_PENDING,
|
||||
};
|
||||
|
||||
|
|
|
@ -259,8 +259,7 @@ void flow_offload_refresh(struct nf_flowtable *flow_table,
|
|||
{
|
||||
flow->timeout = nf_flowtable_time_stamp + NF_FLOW_TIMEOUT;
|
||||
|
||||
if (likely(!nf_flowtable_hw_offload(flow_table) ||
|
||||
!test_and_clear_bit(NF_FLOW_HW_REFRESH, &flow->flags)))
|
||||
if (likely(!nf_flowtable_hw_offload(flow_table)))
|
||||
return;
|
||||
|
||||
nf_flow_offload_add(flow_table, flow);
|
||||
|
|
|
@ -753,10 +753,11 @@ static void flow_offload_work_add(struct flow_offload_work *offload)
|
|||
|
||||
err = flow_offload_rule_add(offload, flow_rule);
|
||||
if (err < 0)
|
||||
set_bit(NF_FLOW_HW_REFRESH, &offload->flow->flags);
|
||||
else
|
||||
set_bit(IPS_HW_OFFLOAD_BIT, &offload->flow->ct->status);
|
||||
goto out;
|
||||
|
||||
set_bit(IPS_HW_OFFLOAD_BIT, &offload->flow->ct->status);
|
||||
|
||||
out:
|
||||
nf_flow_offload_destroy(flow_rule);
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue