mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-06 02:50:43 +00:00
spi: dw: Fix default polarity of native chipselect
The DW controller also supports platforms specifying
native chipselects. When I enforce the use of high CS
for drivers opting in for using GPIO descriptors, I
inadvertedly switched the driver to also use active
high chip select for native chip selects.
As it turns out, the DW hardware driving chip selects
also thinks it is weird with active low chip selects
so all we need to do is remove an inversion in the
driver.
Cc: Jan Kotas <jank@cadence.com>
Reported-by: Jan Kotas <jank@cadence.com>
Tested-by: Jan Kotas <jank@cadence.com>
Fixes: 9400c41e77
("spi: dw: Convert to use CS GPIO descriptors")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
parent
2df201e006
commit
6e0a32d6f3
1 changed files with 2 additions and 3 deletions
|
@ -137,11 +137,10 @@ void dw_spi_set_cs(struct spi_device *spi, bool enable)
|
||||||
struct dw_spi *dws = spi_controller_get_devdata(spi->controller);
|
struct dw_spi *dws = spi_controller_get_devdata(spi->controller);
|
||||||
struct chip_data *chip = spi_get_ctldata(spi);
|
struct chip_data *chip = spi_get_ctldata(spi);
|
||||||
|
|
||||||
/* Chip select logic is inverted from spi_set_cs() */
|
|
||||||
if (chip && chip->cs_control)
|
if (chip && chip->cs_control)
|
||||||
chip->cs_control(!enable);
|
chip->cs_control(enable);
|
||||||
|
|
||||||
if (!enable)
|
if (enable)
|
||||||
dw_writel(dws, DW_SPI_SER, BIT(spi->chip_select));
|
dw_writel(dws, DW_SPI_SER, BIT(spi->chip_select));
|
||||||
else if (dws->cs_override)
|
else if (dws->cs_override)
|
||||||
dw_writel(dws, DW_SPI_SER, 0);
|
dw_writel(dws, DW_SPI_SER, 0);
|
||||||
|
|
Loading…
Reference in a new issue