mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-04 16:15:11 +00:00
Code Issues Releases Wiki Activity

ASoC: meson: aiu: fix irq registration

Browse source 
The aiu stored the irq in an unsigned integer which may have discarded an
error returned by platform_get_irq_byname(). This is incorrect and should
have been a signed integer.

Also drop the irq error traces from the probe function as this is already
done by platform_get_irq_byname().

Fixes: 6ae9ca9ce9 ("ASoC: meson: aiu: add i2s and spdif support")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Link: https://lore.kernel.org/r/20200214131350.337968-4-jbrunet@baylibre.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Jerome Brunet 2020-02-14 14:13:48 +01:00 committed by Mark Brown
parent 269f001712
commit 6e700f0672
No known key found for this signature in database
GPG key ID: 24D68B725D5487D0
2 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
sound/soc/meson/aiu.c
View file

@ -314,16 +314,12 @@ static int aiu_probe(struct platform_device *pdev)
}
aiu->i2s.irq = platform_get_irq_byname(pdev, "i2s");
if (aiu->i2s.irq < 0) {
dev_err(dev, "Can't get i2s irq\n");
if (aiu->i2s.irq < 0)
return aiu->i2s.irq;
}
aiu->spdif.irq = platform_get_irq_byname(pdev, "spdif");
if (aiu->spdif.irq < 0) {
dev_err(dev, "Can't get spdif irq\n");
if (aiu->spdif.irq < 0)
return aiu->spdif.irq;
}
ret = aiu_clk_get(dev);
if (ret)

2
sound/soc/meson/aiu.h
View file

@ -26,7 +26,7 @@ enum aiu_clk_ids {
struct aiu_interface {
struct clk_bulk_data *clks;
unsigned int clk_num;
unsigned int irq;
int irq;
};
struct aiu {