mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-29 23:53:32 +00:00
target/iscsi: Detect conn_cmd_list corruption early
Certain behavior of the initiator can cause the target driver to send both a reject and a SCSI response. If that happens two target_put_sess_cmd() calls will occur without the command having been removed from conn_cmd_list. In other words, conn_cmd_list will get corrupted once the freed memory is reused. Although the Linux kernel can detect list corruption if list debugging is enabled, in this case the context in which list corruption is detected is not related to the context that caused list corruption. Hence add WARN_ON() statements that report the context that is causing list corruption. Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com> Cc: Christoph Hellwig <hch@lst.de> Cc: Mike Christie <mchristi@redhat.com> Reviewed-by: Hannes Reinecke <hare@suse.com> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
parent
cfe2b621bb
commit
6eaf69e4ec
1 changed files with 4 additions and 0 deletions
|
@ -694,6 +694,8 @@ void iscsit_release_cmd(struct iscsi_cmd *cmd)
|
|||
struct iscsi_session *sess;
|
||||
struct se_cmd *se_cmd = &cmd->se_cmd;
|
||||
|
||||
WARN_ON(!list_empty(&cmd->i_conn_node));
|
||||
|
||||
if (cmd->conn)
|
||||
sess = cmd->conn->sess;
|
||||
else
|
||||
|
@ -716,6 +718,8 @@ void __iscsit_free_cmd(struct iscsi_cmd *cmd, bool check_queues)
|
|||
{
|
||||
struct iscsi_conn *conn = cmd->conn;
|
||||
|
||||
WARN_ON(!list_empty(&cmd->i_conn_node));
|
||||
|
||||
if (cmd->data_direction == DMA_TO_DEVICE) {
|
||||
iscsit_stop_dataout_timer(cmd);
|
||||
iscsit_free_r2ts_from_list(cmd);
|
||||
|
|
Loading…
Reference in a new issue