mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-28 21:33:52 +00:00
Code Issues Releases Wiki Activity

arm: dts: vexpress-v2p-ca15_a7: disable NOR flash node by default

Browse source 
Accessing the NOR flash memory from the kernel will disrupt CPU sleep/
idles states and CPU hotplugging. We need to disable this DT node by
default. Setups that want to access the flash can modify this entry to
enable the flash again but also ensuring to disable CPU idle states and
CPU hotplug.

The platform firmware assumes the flash is always in read mode while
Linux kernel driver leaves NOR flash in "read id" mode after
initialization. If it gets used actively, it can be in some other state.

So far we had not seen this issue as the NOR flash drivers in kernel
were not enabled by default. However it was enable in multi_v7 config by
Commit 5f068190cc ("ARM: multi_v7_defconfig: Enable support for CFI NOR FLASH")

So, let's mark the NOR flash disabled so that the platform can boot
again. This based on:
Commit 980bbff018 ("ARM64: juno: disable NOR flash node by default")

Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
This commit is contained in:
Sudeep Holla 2019-05-29 14:29:45 +01:00
parent 8de9336f4b
commit 6f3710f1f6
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
arch/arm/boot/dts/vexpress-v2m-rs1.dtsi
View file

@ -30,7 +30,7 @@ motherboard {
#interrupt-cells = <1>;
ranges;
flash@0,00000000 {
nor_flash: flash@0,00000000 {
compatible = "arm,vexpress-flash", "cfi-flash";
reg = <0 0x00000000 0x04000000>,
<4 0x00000000 0x04000000>;

9
arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts
View file

@ -680,3 +680,12 @@ site2: hsb@40000000 {
<0 3 &gic 0 39 4>;
};
};
&nor_flash {
/*
* Unfortunately, accessing the flash disturbs the CPU idle states
* (suspend) and CPU hotplug of this platform. For this reason, flash
* hardware access is disabled by default on this platform alone.
*/
status = "disabled";
};