mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-21 10:01:00 +00:00
fbdev: zero-fill colormap in fbcmap.c
commit 19ab233989
upstream.
Use kzalloc() rather than kmalloc() for the dynamically allocated parts
of the colormap in fb_alloc_cmap_gfp, to prevent a leak of random kernel
data to userspace under certain circumstances.
Fixes a KMSAN-found infoleak bug reported by syzbot at:
https://syzkaller.appspot.com/bug?id=741578659feabd108ad9e06696f0c1f2e69c4b6e
Reported-by: syzbot+47fa9c9c648b765305b9@syzkaller.appspotmail.com
Cc: stable <stable@vger.kernel.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210331220719.1499743-1-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
af830b27c3
commit
6f85f04972
1 changed files with 4 additions and 4 deletions
|
@ -101,17 +101,17 @@ int fb_alloc_cmap_gfp(struct fb_cmap *cmap, int len, int transp, gfp_t flags)
|
||||||
if (!len)
|
if (!len)
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
cmap->red = kmalloc(size, flags);
|
cmap->red = kzalloc(size, flags);
|
||||||
if (!cmap->red)
|
if (!cmap->red)
|
||||||
goto fail;
|
goto fail;
|
||||||
cmap->green = kmalloc(size, flags);
|
cmap->green = kzalloc(size, flags);
|
||||||
if (!cmap->green)
|
if (!cmap->green)
|
||||||
goto fail;
|
goto fail;
|
||||||
cmap->blue = kmalloc(size, flags);
|
cmap->blue = kzalloc(size, flags);
|
||||||
if (!cmap->blue)
|
if (!cmap->blue)
|
||||||
goto fail;
|
goto fail;
|
||||||
if (transp) {
|
if (transp) {
|
||||||
cmap->transp = kmalloc(size, flags);
|
cmap->transp = kzalloc(size, flags);
|
||||||
if (!cmap->transp)
|
if (!cmap->transp)
|
||||||
goto fail;
|
goto fail;
|
||||||
} else {
|
} else {
|
||||||
|
|
Loading…
Reference in a new issue