mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-04 08:08:54 +00:00
Code Issues Releases Wiki Activity

btrfs: consolidate btrfs_previous_item ret val handling in btrfs_shrink_device

Browse source 
Instead of having three 'if' to handle non-NULL return value consolidate
this in one 'if (ret)'. That way the code is more obvious:

 - Always drop delete_unused_bgs_mutex if ret is not NULL
 - If ret is negative -> goto done
 - If it's 1 -> reset ret to 0, release the path and finish the loop.

Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Nikolay Borisov 2020-12-17 15:21:16 +02:00 committed by David Sterba
parent 1478143ac8
commit 7056bf69e5
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
fs/btrfs/volumes.c
View file

@ -4668,11 +4668,10 @@ int btrfs_shrink_device(struct btrfs_device *device, u64 new_size)
}
ret = btrfs_previous_item(root, path, 0, key.type);
if (ret)
mutex_unlock(&fs_info->delete_unused_bgs_mutex);
if (ret < 0)
goto done;
if (ret) {
mutex_unlock(&fs_info->delete_unused_bgs_mutex);
if (ret < 0)
goto done;
ret = 0;
btrfs_release_path(path);
break;