mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 11:19:37 +00:00
regulator: core: remove some dead code
Originally queue_delayed_work() used to negative error codes or 0 and 1
on success depending if the work was queued or not. It caused a lot of
bugs where people treated all non-zero returns as failures so we changed
it to return bool instead in d4283e9378
('workqueue: make queueing
functions return bool'). Now it never returns failure.
Checking for negative values causes a static checker warning since it is
impossible based on the bool type.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
parent
83080a1408
commit
70dc6daff0
1 changed files with 3 additions and 8 deletions
|
@ -2368,7 +2368,6 @@ static void regulator_disable_work(struct work_struct *work)
|
||||||
int regulator_disable_deferred(struct regulator *regulator, int ms)
|
int regulator_disable_deferred(struct regulator *regulator, int ms)
|
||||||
{
|
{
|
||||||
struct regulator_dev *rdev = regulator->rdev;
|
struct regulator_dev *rdev = regulator->rdev;
|
||||||
int ret;
|
|
||||||
|
|
||||||
if (regulator->always_on)
|
if (regulator->always_on)
|
||||||
return 0;
|
return 0;
|
||||||
|
@ -2380,13 +2379,9 @@ int regulator_disable_deferred(struct regulator *regulator, int ms)
|
||||||
rdev->deferred_disables++;
|
rdev->deferred_disables++;
|
||||||
mutex_unlock(&rdev->mutex);
|
mutex_unlock(&rdev->mutex);
|
||||||
|
|
||||||
ret = queue_delayed_work(system_power_efficient_wq,
|
queue_delayed_work(system_power_efficient_wq, &rdev->disable_work,
|
||||||
&rdev->disable_work,
|
msecs_to_jiffies(ms));
|
||||||
msecs_to_jiffies(ms));
|
return 0;
|
||||||
if (ret < 0)
|
|
||||||
return ret;
|
|
||||||
else
|
|
||||||
return 0;
|
|
||||||
}
|
}
|
||||||
EXPORT_SYMBOL_GPL(regulator_disable_deferred);
|
EXPORT_SYMBOL_GPL(regulator_disable_deferred);
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue