mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-25 18:30:06 +00:00
ALSA: timer: Reject user params with too small ticks
When a user sets a too small ticks with a fine-grained timer like hrtimer, the kernel tries to fire up the timer irq too frequently. This may lead to the condensed locks, eventually the kernel spinlock lockup with warnings. For avoiding such a situation, we define a lower limit of the resolution, namely 1ms. When the user passes a too small tick value that results in less than that, the kernel returns -EINVAL now. Reported-by: Dmitry Vyukov <dvyukov@google.com> Cc: <stable@vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
parent
126cfa2f5e
commit
71321eb3f2
1 changed files with 15 additions and 3 deletions
|
@ -1702,10 +1702,22 @@ static int snd_timer_user_params(struct file *file,
|
|||
return -EBADFD;
|
||||
if (copy_from_user(¶ms, _params, sizeof(params)))
|
||||
return -EFAULT;
|
||||
if (!(t->hw.flags & SNDRV_TIMER_HW_SLAVE) && params.ticks < 1) {
|
||||
if (!(t->hw.flags & SNDRV_TIMER_HW_SLAVE)) {
|
||||
u64 resolution;
|
||||
|
||||
if (params.ticks < 1) {
|
||||
err = -EINVAL;
|
||||
goto _end;
|
||||
}
|
||||
|
||||
/* Don't allow resolution less than 1ms */
|
||||
resolution = snd_timer_resolution(tu->timeri);
|
||||
resolution *= params.ticks;
|
||||
if (resolution < 1000000) {
|
||||
err = -EINVAL;
|
||||
goto _end;
|
||||
}
|
||||
}
|
||||
if (params.queue_size > 0 &&
|
||||
(params.queue_size < 32 || params.queue_size > 1024)) {
|
||||
err = -EINVAL;
|
||||
|
|
Loading…
Reference in a new issue