mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-25 10:19:47 +00:00
NFSv4: Warn once about servers that incorrectly apply open mode to setattr
Debugging aid to help identify servers that incorrectly apply open mode checks to setattr requests that are not changing the file size. Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
This commit is contained in:
parent
ee3ae84ef4
commit
721ccfb79b
1 changed files with 7 additions and 0 deletions
|
@ -2184,6 +2184,13 @@ static int nfs4_do_setattr(struct inode *inode, struct rpc_cred *cred,
|
|||
err = _nfs4_do_setattr(inode, cred, fattr, sattr, state);
|
||||
switch (err) {
|
||||
case -NFS4ERR_OPENMODE:
|
||||
if (!(sattr->ia_valid & ATTR_SIZE)) {
|
||||
pr_warn_once("NFSv4: server %s is incorrectly "
|
||||
"applying open mode checks to "
|
||||
"a SETATTR that is not "
|
||||
"changing file size.\n",
|
||||
server->nfs_client->cl_hostname);
|
||||
}
|
||||
if (state && !(state->state & FMODE_WRITE)) {
|
||||
err = -EBADF;
|
||||
if (sattr->ia_valid & ATTR_OPEN)
|
||||
|
|
Loading…
Reference in a new issue