mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-04 09:59:32 +00:00
habanalabs: check pad and reserved fields in ioctls
Make sure all reserved/pad fields in uapi input structures are set to 0. Signed-off-by: farah kassabri <fkassabri@habana.ai> Reviewed-by: Oded Gabbay <ogabbay@kernel.org> Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
This commit is contained in:
parent
0970380a7e
commit
72848de04b
2 changed files with 19 additions and 2 deletions
|
@ -1310,6 +1310,13 @@ static int hl_cs_sanity_checks(struct hl_fpriv *hpriv, union hl_cs_args *args)
|
|||
enum hl_device_status status;
|
||||
enum hl_cs_type cs_type;
|
||||
bool is_sync_stream;
|
||||
int i;
|
||||
|
||||
for (i = 0 ; i < sizeof(args->in.pad) ; i++)
|
||||
if (args->in.pad[i]) {
|
||||
dev_dbg(hdev->dev, "Padding bytes must be 0\n");
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
if (!hl_device_operational(hdev, &status)) {
|
||||
return -EBUSY;
|
||||
|
@ -2918,7 +2925,13 @@ static int hl_multi_cs_wait_ioctl(struct hl_fpriv *hpriv, void *data)
|
|||
u32 size_to_copy;
|
||||
u64 *cs_seq_arr;
|
||||
u8 seq_arr_len;
|
||||
int rc;
|
||||
int rc, i;
|
||||
|
||||
for (i = 0 ; i < sizeof(args->in.pad) ; i++)
|
||||
if (args->in.pad[i]) {
|
||||
dev_dbg(hdev->dev, "Padding bytes must be 0\n");
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
if (!hdev->supports_wait_for_multi_cs) {
|
||||
dev_err(hdev->dev, "Wait for multi CS is not supported\n");
|
||||
|
|
|
@ -884,9 +884,13 @@ static int _hl_info_ioctl(struct hl_fpriv *hpriv, void *data,
|
|||
enum hl_device_status status;
|
||||
struct hl_info_args *args = data;
|
||||
struct hl_device *hdev = hpriv->hdev;
|
||||
|
||||
int rc;
|
||||
|
||||
if (args->pad) {
|
||||
dev_dbg(hdev->dev, "Padding bytes must be 0\n");
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
/*
|
||||
* Information is returned for the following opcodes even if the device
|
||||
* is disabled or in reset.
|
||||
|
|
Loading…
Reference in a new issue