mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-06 02:50:43 +00:00
dwc2: gadget: Fix ISOC IN DDMA PID bitfield value calculation
[ Upstream commit 1d8e5c0027
]
PID bitfield in descriptor should be set based on particular request
length, not based on EP's mc value. PID value can't be set to 0 even
request length is 0.
Signed-off-by: Minas Harutyunyan <hminas@synopsys.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
6958ade76b
commit
72bc7a2f77
1 changed files with 6 additions and 1 deletions
|
@ -848,6 +848,7 @@ static int dwc2_gadget_fill_isoc_desc(struct dwc2_hsotg_ep *hs_ep,
|
|||
u32 index;
|
||||
u32 maxsize = 0;
|
||||
u32 mask = 0;
|
||||
u8 pid = 0;
|
||||
|
||||
maxsize = dwc2_gadget_get_desc_params(hs_ep, &mask);
|
||||
if (len > maxsize) {
|
||||
|
@ -893,7 +894,11 @@ static int dwc2_gadget_fill_isoc_desc(struct dwc2_hsotg_ep *hs_ep,
|
|||
((len << DEV_DMA_NBYTES_SHIFT) & mask));
|
||||
|
||||
if (hs_ep->dir_in) {
|
||||
desc->status |= ((hs_ep->mc << DEV_DMA_ISOC_PID_SHIFT) &
|
||||
if (len)
|
||||
pid = DIV_ROUND_UP(len, hs_ep->ep.maxpacket);
|
||||
else
|
||||
pid = 1;
|
||||
desc->status |= ((pid << DEV_DMA_ISOC_PID_SHIFT) &
|
||||
DEV_DMA_ISOC_PID_MASK) |
|
||||
((len % hs_ep->ep.maxpacket) ?
|
||||
DEV_DMA_SHORT : 0) |
|
||||
|
|
Loading…
Reference in a new issue