mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 22:02:02 +00:00
media: pci: cx23885: fix error handling for cx23885 ATSC boards
[ Upstream commit 4aaa96b59d
]
After having been assigned to NULL value at cx23885-dvb.c:1202,
pointer '0' is dereferenced at cx23885-dvb.c:2469.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Nikolay Burykin <burikin@ivk.ru>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
eb3c2b3519
commit
72c90ebb2d
1 changed files with 0 additions and 12 deletions
|
@ -2459,16 +2459,10 @@ static int dvb_register(struct cx23885_tsport *port)
|
|||
request_module("%s", info.type);
|
||||
client_tuner = i2c_new_client_device(&dev->i2c_bus[1].i2c_adap, &info);
|
||||
if (!i2c_client_has_driver(client_tuner)) {
|
||||
module_put(client_demod->dev.driver->owner);
|
||||
i2c_unregister_device(client_demod);
|
||||
port->i2c_client_demod = NULL;
|
||||
goto frontend_detach;
|
||||
}
|
||||
if (!try_module_get(client_tuner->dev.driver->owner)) {
|
||||
i2c_unregister_device(client_tuner);
|
||||
module_put(client_demod->dev.driver->owner);
|
||||
i2c_unregister_device(client_demod);
|
||||
port->i2c_client_demod = NULL;
|
||||
goto frontend_detach;
|
||||
}
|
||||
port->i2c_client_tuner = client_tuner;
|
||||
|
@ -2505,16 +2499,10 @@ static int dvb_register(struct cx23885_tsport *port)
|
|||
request_module("%s", info.type);
|
||||
client_tuner = i2c_new_client_device(&dev->i2c_bus[1].i2c_adap, &info);
|
||||
if (!i2c_client_has_driver(client_tuner)) {
|
||||
module_put(client_demod->dev.driver->owner);
|
||||
i2c_unregister_device(client_demod);
|
||||
port->i2c_client_demod = NULL;
|
||||
goto frontend_detach;
|
||||
}
|
||||
if (!try_module_get(client_tuner->dev.driver->owner)) {
|
||||
i2c_unregister_device(client_tuner);
|
||||
module_put(client_demod->dev.driver->owner);
|
||||
i2c_unregister_device(client_demod);
|
||||
port->i2c_client_demod = NULL;
|
||||
goto frontend_detach;
|
||||
}
|
||||
port->i2c_client_tuner = client_tuner;
|
||||
|
|
Loading…
Reference in a new issue