mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 19:00:25 +00:00
drivers/dma: Correct NULL test
cohd_fin has already been verified not to be NULL, so the argument to BUG_ON cannot be true. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ expression *x; expression e; identifier l; @@ if (x == NULL || ...) { ... when forall return ...; } ... when != goto l; when != x = e when != &x *x == NULL // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Acked-by: Linus Walleij <linus.walleij@stericsson.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
parent
8f98781e0f
commit
734c299282
1 changed files with 0 additions and 2 deletions
|
@ -613,8 +613,6 @@ static void dma_tasklet(unsigned long data)
|
||||||
cohd_fin->pending_irqs--;
|
cohd_fin->pending_irqs--;
|
||||||
cohc->completed = cohd_fin->desc.cookie;
|
cohc->completed = cohd_fin->desc.cookie;
|
||||||
|
|
||||||
BUG_ON(cohc->nbr_active_done && cohd_fin == NULL);
|
|
||||||
|
|
||||||
if (cohc->nbr_active_done == 0)
|
if (cohc->nbr_active_done == 0)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue