mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 19:00:25 +00:00
cfg80211: regulatory: remove a bogus initialization
The the __freq_reg_info() never returns NULL and the callers don't check for NULL. This initialization to set "reg_rule = NULL;" is just there to make GCC happy but it's not required in current GCCs. The problem is that Smatch sees the initialization and concludes that this function can return NULL so it complains that the callers are not checking for it. Smatch used to be able to parse this correctly but we recently changed the code from: - for (bw = MHZ_TO_KHZ(20); bw >= min_bw; bw = bw / 2) { + for (bw = MHZ_TO_KHZ(bws[i]); bw >= min_bw; bw = MHZ_TO_KHZ(bws[i--])) { Originally Smatch used to understand that this code always iterates through the loop once, but the change from "MHZ_TO_KHZ(20)" to "MHZ_TO_KHZ(bws[i])" is too complicated for Smatch. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Link: https://lore.kernel.org/r/20200923084203.GC1454948@mwanda Signed-off-by: Johannes Berg <johannes.berg@intel.com>
This commit is contained in:
parent
e3f25908b0
commit
735b267394
1 changed files with 1 additions and 1 deletions
|
@ -1616,8 +1616,8 @@ static const struct ieee80211_reg_rule *
|
||||||
__freq_reg_info(struct wiphy *wiphy, u32 center_freq, u32 min_bw)
|
__freq_reg_info(struct wiphy *wiphy, u32 center_freq, u32 min_bw)
|
||||||
{
|
{
|
||||||
const struct ieee80211_regdomain *regd = reg_get_regdomain(wiphy);
|
const struct ieee80211_regdomain *regd = reg_get_regdomain(wiphy);
|
||||||
const struct ieee80211_reg_rule *reg_rule = NULL;
|
|
||||||
const u32 bws[] = {0, 1, 2, 4, 5, 8, 10, 16, 20};
|
const u32 bws[] = {0, 1, 2, 4, 5, 8, 10, 16, 20};
|
||||||
|
const struct ieee80211_reg_rule *reg_rule;
|
||||||
int i = ARRAY_SIZE(bws) - 1;
|
int i = ARRAY_SIZE(bws) - 1;
|
||||||
u32 bw;
|
u32 bw;
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue