From 73ded163e5ec47d229683b32c501e548b745d032 Mon Sep 17 00:00:00 2001 From: Kent Overstreet Date: Sat, 12 Aug 2023 16:46:54 -0400 Subject: [PATCH] bcachefs: Add a comment for should_drop_open_bucket() Signed-off-by: Kent Overstreet --- fs/bcachefs/alloc_foreground.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/fs/bcachefs/alloc_foreground.c b/fs/bcachefs/alloc_foreground.c index 089185a661ee..e02749ddc362 100644 --- a/fs/bcachefs/alloc_foreground.c +++ b/fs/bcachefs/alloc_foreground.c @@ -989,7 +989,6 @@ static int __open_bucket_add_buckets(struct btree_trans *trans, cl = _cl; goto retry_blocking; } - } return ret; @@ -1031,6 +1030,16 @@ static int open_bucket_add_buckets(struct btree_trans *trans, return ret < 0 ? ret : 0; } +/** + * should_drop_bucket - check if this is open_bucket should go away + * @ca: if set, we're killing buckets for a particular device + * @ec: if true, we're shutting down erasure coding and killing all ec + * open_buckets + * otherwise, return true + * + * We're killing open_buckets because we're shutting down a device, erasure + * coding, or the entire filesystem - check if this open_bucket matches: + */ static bool should_drop_bucket(struct open_bucket *ob, struct bch_fs *c, struct bch_dev *ca, bool ec) {