mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-30 08:02:30 +00:00
habanalabs: add WARN in case of bad MMU mapping
This patch checks if an MMU mapping is erroneous in that the physical address that is being mapped is NOT divisible by the page size. If that thing happens, then the H/W will issue a transaction which will be translated to a wrong address, because part of the address will not be taken (the remainder of address/page size). Because the physical address is being handled by the driver, a WARN is suitable here as it implies a bug in the driver code itself and not a user bug. Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
This commit is contained in:
parent
2a51558c8c
commit
747bf88c61
1 changed files with 4 additions and 0 deletions
|
@ -913,6 +913,10 @@ int hl_mmu_map(struct hl_ctx *ctx, u64 virt_addr, u64 phys_addr, u32 page_size)
|
|||
return -EFAULT;
|
||||
}
|
||||
|
||||
WARN_ONCE((phys_addr & (real_page_size - 1)),
|
||||
"Mapping 0x%llx with page size of 0x%x is erroneous! Address must be divisible by page size",
|
||||
phys_addr, real_page_size);
|
||||
|
||||
npages = page_size / real_page_size;
|
||||
real_virt_addr = virt_addr;
|
||||
real_phys_addr = phys_addr;
|
||||
|
|
Loading…
Reference in a new issue