mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-30 08:02:30 +00:00
net: netxen: correct sysfs bin attribute return code
If read() syscall requests unexpected number of bytes from "dimm" binary attribute file, return EINVAL instead of EPERM. At the same time pin down sysfs file size to the fixed sizeof(struct netxen_dimm_cfg), which allows to exploit some missing sanity checks from kernfs (file boundary checks vs offset etc.) Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
082739aa45
commit
748a7295d7
1 changed files with 3 additions and 3 deletions
|
@ -3025,9 +3025,9 @@ netxen_sysfs_read_dimm(struct file *filp, struct kobject *kobj,
|
|||
u8 dw, rows, cols, banks, ranks;
|
||||
u32 val;
|
||||
|
||||
if (size != sizeof(struct netxen_dimm_cfg)) {
|
||||
if (size < attr->size) {
|
||||
netdev_err(netdev, "Invalid size\n");
|
||||
return -1;
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
memset(&dimm, 0, sizeof(struct netxen_dimm_cfg));
|
||||
|
@ -3137,7 +3137,7 @@ netxen_sysfs_read_dimm(struct file *filp, struct kobject *kobj,
|
|||
|
||||
static struct bin_attribute bin_attr_dimm = {
|
||||
.attr = { .name = "dimm", .mode = (S_IRUGO | S_IWUSR) },
|
||||
.size = 0,
|
||||
.size = sizeof(struct netxen_dimm_cfg),
|
||||
.read = netxen_sysfs_read_dimm,
|
||||
};
|
||||
|
||||
|
|
Loading…
Reference in a new issue