virtio-balloon: remove BUG() in init_vqs
It's a bit overkill to use BUG when failing to add an entry to the stats_vq in init_vqs. So remove it and just return the error to the caller to bail out nicely. Signed-off-by: Wei Wang <wei.w.wang@intel.com> Cc: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
parent
94710cac0e
commit
74cf5b169c
|
@ -455,9 +455,13 @@ static int init_vqs(struct virtio_balloon *vb)
|
||||||
num_stats = update_balloon_stats(vb);
|
num_stats = update_balloon_stats(vb);
|
||||||
|
|
||||||
sg_init_one(&sg, vb->stats, sizeof(vb->stats[0]) * num_stats);
|
sg_init_one(&sg, vb->stats, sizeof(vb->stats[0]) * num_stats);
|
||||||
if (virtqueue_add_outbuf(vb->stats_vq, &sg, 1, vb, GFP_KERNEL)
|
err = virtqueue_add_outbuf(vb->stats_vq, &sg, 1, vb,
|
||||||
< 0)
|
GFP_KERNEL);
|
||||||
BUG();
|
if (err) {
|
||||||
|
dev_warn(&vb->vdev->dev, "%s: add stat_vq failed\n",
|
||||||
|
__func__);
|
||||||
|
return err;
|
||||||
|
}
|
||||||
virtqueue_kick(vb->stats_vq);
|
virtqueue_kick(vb->stats_vq);
|
||||||
}
|
}
|
||||||
return 0;
|
return 0;
|
||||||
|
|
Loading…
Reference in New Issue