mirrors
/
linux-stable
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
1
0
Fork 0
Code Issues Releases Wiki Activity

[media] dib0090: Fix a warning at dib0090_set_EFUSE 

The check if the values for c, h and n are within the range is
always true, as, if one of this values is out of range, the
previous "if" clauses will default to a value within the
range.

That fixes the following warning:

	drivers/media/dvb-frontends/dib0090.c: In function 'dib0090_set_EFUSE':
	drivers/media/dvb-frontends/dib0090.c:1545:5: warning: comparison is always true due to limited range of data type [-Wtype-limits]

and makes the code easier to read.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Mauro Carvalho Chehab 2013-04-25 15:30:40 -03:00
parent 13122f98c6
commit 751dc8c7fa
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/media/dvb-frontends/dib0090.c
View File

@ -1540,13 +1540,9 @@ static void dib0090_set_EFUSE(struct dib0090_state *state)
if ((n >= POLY_MAX) || (n <= POLY_MIN))
n = 3;
if ((c >= CAP_VALUE_MIN) && (c <= CAP_VALUE_MAX)
&& (h >= HR_MIN) && (h <= HR_MAX)
&& (n >= POLY_MIN) && (n <= POLY_MAX)) {
dib0090_write_reg(state, 0x13, (h << 10));
e2 = (n << 11) | ((h >> 2)<<6) | c;
dib0090_write_reg(state, 0x2, e2); /* Load the BB_2 */
}
dib0090_write_reg(state, 0x13, (h << 10));
e2 = (n << 11) | ((h >> 2)<<6) | c;
dib0090_write_reg(state, 0x2, e2); /* Load the BB_2 */
}
}