mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-14 12:37:32 +00:00
NFS: Fix the locking in nfs4_callback_getattr
The delegation is protected by RCU now, so we need to replace the nfsi->rwsem protection with an rcu protected section. Reported-by: Fred Isaman <iisaman@netapp.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
This commit is contained in:
parent
0d8a374673
commit
761fe93cdf
1 changed files with 3 additions and 3 deletions
|
@ -37,8 +37,8 @@ __be32 nfs4_callback_getattr(struct cb_getattrargs *args, struct cb_getattrres *
|
||||||
if (inode == NULL)
|
if (inode == NULL)
|
||||||
goto out_putclient;
|
goto out_putclient;
|
||||||
nfsi = NFS_I(inode);
|
nfsi = NFS_I(inode);
|
||||||
down_read(&nfsi->rwsem);
|
rcu_read_lock();
|
||||||
delegation = nfsi->delegation;
|
delegation = rcu_dereference(nfsi->delegation);
|
||||||
if (delegation == NULL || (delegation->type & FMODE_WRITE) == 0)
|
if (delegation == NULL || (delegation->type & FMODE_WRITE) == 0)
|
||||||
goto out_iput;
|
goto out_iput;
|
||||||
res->size = i_size_read(inode);
|
res->size = i_size_read(inode);
|
||||||
|
@ -53,7 +53,7 @@ __be32 nfs4_callback_getattr(struct cb_getattrargs *args, struct cb_getattrres *
|
||||||
args->bitmap[1];
|
args->bitmap[1];
|
||||||
res->status = 0;
|
res->status = 0;
|
||||||
out_iput:
|
out_iput:
|
||||||
up_read(&nfsi->rwsem);
|
rcu_read_unlock();
|
||||||
iput(inode);
|
iput(inode);
|
||||||
out_putclient:
|
out_putclient:
|
||||||
nfs_put_client(clp);
|
nfs_put_client(clp);
|
||||||
|
|
Loading…
Reference in a new issue