mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 01:10:04 +00:00
iscsi-target: Fix uninitialized usage of cmd->pad_bytes
This patch fixes an uninitialized usage of cmd->pad_bytes inside of iscsit_handle_text_cmd() introduced during a v4.1 change to use cmd members instead of local pad_bytes variables. Reported-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
parent
8f50c7f5d6
commit
76f1928e88
1 changed files with 3 additions and 3 deletions
|
@ -1857,7 +1857,7 @@ static int iscsit_handle_text_cmd(
|
|||
char *text_ptr, *text_in;
|
||||
int cmdsn_ret, niov = 0, rx_got, rx_size;
|
||||
u32 checksum = 0, data_crc = 0, payload_length;
|
||||
u32 padding = 0, text_length = 0;
|
||||
u32 padding = 0, pad_bytes = 0, text_length = 0;
|
||||
struct iscsi_cmd *cmd;
|
||||
struct kvec iov[3];
|
||||
struct iscsi_text *hdr;
|
||||
|
@ -1896,7 +1896,7 @@ static int iscsit_handle_text_cmd(
|
|||
|
||||
padding = ((-payload_length) & 3);
|
||||
if (padding != 0) {
|
||||
iov[niov].iov_base = cmd->pad_bytes;
|
||||
iov[niov].iov_base = &pad_bytes;
|
||||
iov[niov++].iov_len = padding;
|
||||
rx_size += padding;
|
||||
pr_debug("Receiving %u additional bytes"
|
||||
|
@ -1917,7 +1917,7 @@ static int iscsit_handle_text_cmd(
|
|||
if (conn->conn_ops->DataDigest) {
|
||||
iscsit_do_crypto_hash_buf(&conn->conn_rx_hash,
|
||||
text_in, text_length,
|
||||
padding, cmd->pad_bytes,
|
||||
padding, (u8 *)&pad_bytes,
|
||||
(u8 *)&data_crc);
|
||||
|
||||
if (checksum != data_crc) {
|
||||
|
|
Loading…
Reference in a new issue