scsi: ses: Fix slab-out-of-bounds in ses_intf_remove()

commit 578797f0c8 upstream.

A fix for:

BUG: KASAN: slab-out-of-bounds in ses_intf_remove+0x23f/0x270 [ses]
Read of size 8 at addr ffff88a10d32e5d8 by task rmmod/12013

When edev->components is zero, accessing edev->component[0] members is
wrong.

Link: https://lore.kernel.org/r/20230202162451.15346-5-thenzl@redhat.com
Cc: stable@vger.kernel.org
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Tomas Henzl 2023-02-02 17:24:51 +01:00 committed by Greg Kroah-Hartman
parent 72021ae61a
commit 76f7050537

View file

@ -872,7 +872,8 @@ static void ses_intf_remove_enclosure(struct scsi_device *sdev)
kfree(ses_dev->page2);
kfree(ses_dev);
kfree(edev->component[0].scratch);
if (edev->components)
kfree(edev->component[0].scratch);
put_device(&edev->edev);
enclosure_unregister(edev);