mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-03 15:47:36 +00:00
nfp: fill splittable of devlink_port_attrs correctly
[ Upstream commit4abd9600b9
] The error is reflected in that it shows wrong splittable status of port when executing "devlink port show". The reason which leads the error is that the assigned operation of splittable is just a simple negation operation of split and it does not consider port lanes quantity. A splittable port should have several lanes that can be split(lanes quantity > 1). If without the judgement, it will show wrong message for some firmware, such as 2x25G, 2x10G. Fixes:a0f49b5486
("devlink: Add a new devlink port split ability attribute and pass to netlink") Signed-off-by: Diana Wang <na.wang@corigine.com> Reviewed-by: Louis Peens <louis.peens@corigine.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com> Signed-off-by: Simon Horman <simon.horman@corigine.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
61b7f6db52
commit
7711b5d603
1 changed files with 1 additions and 1 deletions
|
@ -341,7 +341,7 @@ int nfp_devlink_port_register(struct nfp_app *app, struct nfp_port *port)
|
||||||
return ret;
|
return ret;
|
||||||
|
|
||||||
attrs.split = eth_port.is_split;
|
attrs.split = eth_port.is_split;
|
||||||
attrs.splittable = !attrs.split;
|
attrs.splittable = eth_port.port_lanes > 1 && !attrs.split;
|
||||||
attrs.lanes = eth_port.port_lanes;
|
attrs.lanes = eth_port.port_lanes;
|
||||||
attrs.flavour = DEVLINK_PORT_FLAVOUR_PHYSICAL;
|
attrs.flavour = DEVLINK_PORT_FLAVOUR_PHYSICAL;
|
||||||
attrs.phys.port_number = eth_port.label_port;
|
attrs.phys.port_number = eth_port.label_port;
|
||||||
|
|
Loading…
Reference in a new issue